search

nosdav / bookmarks

nosdav bookmarks
https://nosdav.github.io/bookmarks/
MIT License
4 stars 1 forks source link

login ux #14

Closed melvincarvalho closed 2 months ago

melvincarvalho commented 2 months ago
:rocket: This description was created by Ellipsis for commit 22bc4e12d9a98af24e8ba2f9937b3b27d5918340

Summary:

Enhanced the login UX in app.js by adding error handling and user feedback in the userLogin function.

Key points:

Generated with :heart: by ellipsis.dev

melvincarvalho commented 2 months ago

@ellipsis-dev do this: The catch block in the userLogin method does not specify the type of error it is catching. It's recommended to either specify the error type or log the error for better debugging and error handling. Consider adding a parameter to the catch block and logging it. suggestion } catch (error) { console.error(error); Swal.fire({ icon: "error", title: "Oops...", text: "Something went wrong!", footer: '

Please install a nostr extension

' }); }

ellipsis-dev[bot] commented 2 months ago

@melvincarvalho, I have addressed your comments in pull request https://github.com/nosdav/bookmarks/pull/15