nosdav / bookmarks

nosdav bookmarks
https://nosdav.github.io/bookmarks/
MIT License
4 stars 1 forks source link

Fix bug in app.js to maintain bookmark list order #7

Closed sweep-ai[bot] closed 2 months ago

sweep-ai[bot] commented 1 year ago

Description

This PR fixes a bug in the app.js file that was causing the bookmark list to reverse order when a key was pressed. The issue was due to the render() method being called on every key press, causing the list to be re-rendered and reversed. This PR removes the unnecessary reversal of the bookmarks list, ensuring that the bookmarks maintain their original order when being rendered.

Changes Made

Testing

Related Issue

Link to the related issue

Fixes #6.

To checkout this PR branch, run the following command in your terminal:

git checkout sweep/fix-bookmark-list-order
melvincarvalho commented 1 year ago

This is a good fix. But, yes, the original intention was to display the most recently added bookmark first. Could you fix that?