Fix Options - Githubissues

nosdav / server

NosDAV Server

https://nosdav.com/server

MIT License

9 stars 1 forks source link

Fix Options #16

Closed melvincarvalho closed 5 months ago

melvincarvalho commented 5 months ago

:rocket: This description was created by Ellipsis for commit e0e229f5edab9372c10128c45ae9355aa30d85c2

Summary:

This PR updates the README.md to mark certain server options as optional, enhancing documentation clarity.

Key points:

Updated README.md to clarify that -k/--key, -c/--cert, and -o/--owners options are optional.
Improved documentation for better user understanding and usability.

Generated with :heart: by ellipsis.dev

melvincarvalho commented 5 months ago

@elipsis-dev can you create an issue for this?

ellipsis-dev[bot] commented 5 months ago

Sorry, I don't know how to help with that. If you tag me (@ellipsis-dev) in a comment, I can do one of these things (but not multiple at once):

review and summarize this pull request
make changes to this pull request
answer questions about this PR, or about the codebase in general

melvincarvalho commented 5 months ago

@elipsis-dev are the command line arguments well orginaized here?

ellipsis-dev[bot] commented 5 months ago

The command line arguments in the README file appear to be well organized. They are clear, concise, and logically grouped, with optional arguments clearly marked. If there are specific changes or a different organization you would prefer, could you please provide more details?

Responding to this comment by @melvincarvalho. For more information about Ellipsis, check the documentation.

melvincarvalho commented 5 months ago

@elipxis-dev do they match the commands in bin/nosdav.js

melvincarvalho commented 5 months ago

@elipsis-dev do they match the commands in bin/nosdav.js

ellipsis-dev[bot] commented 5 months ago

Yes, the command line arguments listed in the README file do match the ones in the bin/nosdav.js file. Both include the 'key', 'cert', 'port', 'root', 'https', 'mode', and 'owners' arguments. The 'owners' argument is handled as a csv in both places, with the bin/nosdav.js file splitting it into an array for internal use.

Responding to this comment by @melvincarvalho. For more information about Ellipsis, check the documentation.

melvincarvalho commented 5 months ago

@elipsis-dev could the true/false command line options be done better?

ellipsis-dev[bot] commented 5 months ago

@melvincarvalho, I have addressed your comments in pull request https://github.com/nosdav/server/pull/17