Make coverage plugin compatible with Coverage.py 4.1

[mitya57]

According to the Coverage.py 4.1 changelog:

• The Coverage.report function had two parameters with non-None defaults, which have been changed. show_missing used to default to True, but now defaults to None. If you had been calling Coverage.report without specifying show_missing, you'll need to explicitly set it to True to keep the same behavior.

Without that option, four tests in nose fail:

• test_coverage_plugin.TestCoverageMinPercentagePlugin
• test_coverage_plugin.TestCoverageMinPercentageSinglePackagePlugin
• test_coverage_plugin.TestCoverageMinPercentageSinglePackageWithBranchesPlugin
• test_coverage_plugin.TestCoveragePlugin

The example of the failure can be seen in https://bugs.debian.org/828224.

[opoplawski]

Needed to apply this to the Fedora python-nose package to get it to pass tests with converage 4.2, so +1 here.

[jszakmeister]

Nose is unmaintained. Unless someone else takes over maintainership, it's not going to happen. Sorry.

[johnyf]

Is nose2 planned to replace nose? In other words, is it worth for a new maintainer to adopt nose, or should we instead turn our attention to nose2?

In case of the latter, then a note could be added to the README of nose, in order to point people to nose2.

[jszakmeister]

There is a note on the main page of the docs: http://nose.readthedocs.io/en/latest/

Yes, I think you should be looking at Nose 2. It's not compatible with Nose 1.x though. Make sure to read the caveats.

Also, the README is auto-generated. If you put together a proper patch to document that fact, then I'll merge it.

[johnyf]

Thanks for the information. I'll try to create a patch for the code that generates the README.