search

nose-devs / nose

nose is nicer testing for python
http://readthedocs.org/docs/nose/en/latest/
1.36k stars 395 forks source link

Fix NOSE_TESTMATCH default regex. #950

Closed kengruven closed 8 years ago

kengruven commented 9 years ago

See bug #11.

I don't know if this is exactly what's needed, but let's get this party started.

tonysimpson commented 9 years ago

@kengruven I've had a look at this - looks good. I might suggest changing the Config class docstring to include the env.get( this would seem to be the convention but with or without that change I think this needs merging ASAP - this bug is embarrassing.

kengruven commented 9 years ago

Tony, good call. I've made the change you suggested.

kengruven commented 9 years ago

I'm not familiar enough with nose's CI tests to understand why this failed, but it doesn't seem to have anything to do with this PR. (All I did was change a docstring!)

The Python 3.2 test failed in 'coverage', which uses a u''-style string, which isn't valid syntax on that particular version. PR #951 (completely unrelated) is failing for the same reason.

kengruven commented 8 years ago

OK, I've convinced myself it's not a Sphinx bug.

It's was mostly an issue with how nose's OptBucket makes text for Sphinx to parse. This should fix the backslash problem in all 5 places (top of manpage, bottom of manpage, top of README, bottom of README, -h flag). I re-ran make -C doc clean and make -C doc readme man to re-generate those files.

It's not the prettiest thing I've ever written, and I'm not terribly familiar with the Nose internals, so improvements are welcome.

jszakmeister commented 8 years ago

Looks good. Thanks.