katrinabrock
commented
6 years ago @sirosen can you take a look at the coverage related one?
Closed P-EB closed 6 years ago
katrinabrock
commented
6 years ago @sirosen can you take a look at the coverage related one?
sirosen
commented
6 years ago I'll try to take a look this evening.
At a glance, regular coverage reporting is running, but the show-missing setting (i.e. show the lines that were not covered) is not being picked up correctly.
Of course, this passed on my own machine, and on Travis at the time that it merged... Not that that means much now.
I know that coverage released 4.4.2, which is a patch release. I really hope that doesn't matter.
sirosen
commented
6 years ago A quick local run validates that things pass for me, so it's not the version of coverage, at least. The given tox output shows coverage==4.4.2, so it's not like this is failing against Debian packaged python-coverage, though that's something we should test if this is going to be packaged alongside that.
I also tried using py3 and tox=2.5.0 to invoke tox and those don't make a difference... not surprising, I guess. I want to try to reproduce this, but I'm not even sure how. Will give it some more thought.
P-EB
commented
6 years ago @sirosen can I help you in any way?
sirosen
commented
6 years ago @P-EB, thanks for offering, but I was actually just able to reproduce this. Root cause: overthinking the problem and not reading your bug report carefully enough.
We're missing some files from the package data which are required for tests to pass. Because I always run tests from a copy of the repo, and Travis does the same, everything looks good even though this is in error.
At the very least, nose2/tests/functional/support/scenario/test_coverage_config/coveragerc/.coveragerc is missing. I'll open a PR to add this to our MANIFEST.in right away.
I've tried some digging around about the other error you're seeing, but I can't reproduce it -- at least, not as trivially.
sirosen
commented
6 years ago @P-EB, are you sure that your python3.5 interpreter is really python3.5? I wouldn't ask such a crazy question, but the error you're seeing on 3.5 specifically is a python3.6 error. You're on Buster, so I don't know what your environment looks like. Maybe your version of py3.5 was built from an unreleased version?
If you clean up the output a bit (\\n -> \n), then you find that it's a ModuleNotFoundError and ModuleNotFoundError was added in 3.6.
In any case, I'll add py3.6 to the travis builds and setuptools classifiers, and get the requisite fix to the tests in place.
P-EB
commented
6 years ago @sirosen I really think it is python3.5
But maybe I'm wrong.
Anyway, I'll give a try to the version you've patched as soon as it's in pypi and thus ready for packaging. :)
Thanks for taking care of it!
katrinabrock
commented
6 years ago Released, please reopen if your tests are still failing.
P-EB
commented
6 years ago Thanks a lot ! I'll give it a try in the next few days.
P-EB
commented
6 years ago Report:
I: pybuild base:184: python2.7 -m nose2.__main__ -v
*sckrunch sckrunch*
----------------------------------------------------------------------
Ran 246 tests in 83.660s
OK (skipped=1)
I: pybuild base:184: python3.6 -m nose2.__main__ -v
*sckrunch3.6 sckrunch3.6*
----------------------------------------------------------------------
Ran 246 tests in 85.159s
OK (skipped=1)Yay.
I love you guys. \o/
Hi,
I tried to package the new version of nose2 into debian, but the tests fail at build time. I tried with a
tox -vrun on my own laptop with the package provided on pypi, and the same errors occur.I found some issue that were fixed that look the same, so I guess it's kind of easy to solve, but I'm not sure on how to properly solve this.
With python2.7, there is one failure:
With python3.5, there are two of them:
Full log of tox -v on my laptop (buster).