search

noseglasses / elf_diff

A tool to compare ELF binaries
GNU General Public License v3.0
171 stars 21 forks source link

Fix pair report generation (#51) #52

Closed jenswet closed 2 years ago

jenswet commented 2 years ago

Fixes only the first issue of #51

codecov-commenter commented 2 years ago

Codecov Report

Merging #52 (780031f) into master (2a7ad96) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   87.77%   87.89%   +0.12%     
==========================================
  Files          16       16              
  Lines        1660     1661       +1     
==========================================
+ Hits         1457     1460       +3     
+ Misses        203      201       -2
Impacted Files Coverage Δ
src/elf_diff/pair_report.py 91.53% <100.00%> (+0.01%) :arrow_up:
src/elf_diff/git.py 76.47% <0.00%> (+11.76%) :arrow_up:
noseglasses commented 2 years ago

@jenswet, thank you very much for fixing this.

Unfortunately, there was a minor issue in the github PR workflow which caused CI to fail for your pull request. I hope to have fixed it. Would you please rebase your submitted changes on updated master and force push the result on this PR to see if my changes fixed the issue?

jenswet commented 2 years ago

Hi @noseglasses,

Thanks for already reviewing it. That first fix was easy to find. But unfortunately I didn't have time to check the second exception that I commented to #51. So there is still one issue left.

noseglasses commented 2 years ago

Thanks, merged.