noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

atom-build runs forever #441

Closed alex94cp closed 8 years ago

alex94cp commented 8 years ago

This sample .atom-build.yml

cmd: echo foo

Takes forever: screenshot Atom version info:

$ atom -v
Atom    : 1.8.0
Electron: 1.2.2
Chrome  : 51.0.2704.84
Node    : 6.1.0
$ apm list | grep build
├── build@0.64.0
├── build-cmake@0.4.0
├── build-make@0.10.0

UPDATED: fixed typo

noseglid commented 8 years ago

Unable to reproduce this screen shot 2016-06-12 at 16 00 12

Can you provide any other information, such as OS, whether this happens when running a simple node application and spawning echo foo, what shell is running at /bin/sh, etc?

noseglid commented 8 years ago

Just noticed, why is there a semicolon at the end of the command (in the build panel title)?

alex94cp commented 8 years ago

Oh, the semicolon was just a typo, I've just removed it and updated my previous comment.

I'm running atom in Fedora 24 x64, the atom build is from the mosquito/atom copr. I suspect that to be the issue because I'm having lots of version incompatibilities between node, atom, electron and other packages (but because of this that's the only way we can have automatic updates in rpm-based distros such as Fedora :sweat:).

noseglid commented 8 years ago

Hmm, running such an odd setup I think you have to dig down and debug this. Have a quick look in build.js - it's pretty straight forward; it's spawning the specified command, and when the child_process finishes by emitting close, it does appropriate updates to the view.

noseglid commented 8 years ago

Closing due to inactivity.

rilian-la-te commented 7 years ago

I hits the same bug with build-cmake. It seems atom-build unable to catch finish of CMake execution.

noseglid commented 7 years ago

Could you provide more info? Build doesn't really care what it's executing. It's just spawning a child and waiting for it to terminate, cmake is no different from any other executable.

rilian-la-te commented 7 years ago

I am just press F9 for trigger build:) Build executes and correctly finishes, but timer does not stops and indicator runs. Triggering another build is not possible.

atom -v Atom : 1.12.0-beta2 Electron: 1.3.6 Chrome : 52.0.2743.82 Node : 6.3.0

noseglid commented 7 years ago

Can you check if a the cmake process is still running?

rilian-la-te commented 7 years ago

Indicator works also after killing cmake by killing -9

rilian-la-te commented 7 years ago

Killing does not stops endless loop

noseglid commented 7 years ago

Very odd. I see no way this should happen, unless there's a postBuild which rejects its promise but build-cmake doesn't use postBuild.

Can you check if you're getting any errors in the console in Atom?

rilian-la-te commented 7 years ago

No errors in console, but notification appears; screenshot from 2016-10-19 14-10-39

rilian-la-te commented 7 years ago

Console floods with: /bin/sh: mc: line 1: syntax error: unexpected end of file

noseglid commented 7 years ago

That is likely the cause. It has been reported once before: https://github.com/noseglid/atom-build/issues/438

Seems it might be something with sync settings

rilian-la-te commented 7 years ago

How to fix it?

noseglid commented 7 years ago

Not sure. The debug the other guy did indicated that there was in issue with another package which monkey patched stuff. Do you have sync-settings installed ? try and disable it if so

rilian-la-te commented 7 years ago

No, I does not have it installed at home, will test at work.

rilian-la-te commented 7 years ago

At home all works (ArchLinux)

noseglid commented 7 years ago

So what's different in those two environments in terms of OS, installed packages, etc?

rilian-la-te commented 7 years ago

On work I have Atom 0.12b2 from official cite and latest Opensuse tumbleweed. Package from cite uses internal dependencies like Node and Electron. On Arch at home it using standard system packages, Which is more up to date.

On Oct 20, 2016 1:29 PM, "Alexander Olsson" notifications@github.com wrote:

So what's different in those two environements in terms of OS, installed packages, etc?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/noseglid/atom-build/issues/441#issuecomment-255069349, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRJ5u0Wd4xoAj99v2OKHhfltdiL2wMbks5q10J6gaJpZM4Izy8C .

noseglid commented 7 years ago

I have no idea what that version number is. Can you try with an official release from atom.io ?

rilian-la-te commented 7 years ago

At work I am running official release. Not working. At home I am running distro's release - all OK.

rilian-la-te commented 7 years ago

On work there it is. And your extension is not working. But at home there is an Arch repo version - and all is fine.

On Thu, Oct 20, 2016 at 8:07 PM, Alexander Olsson notifications@github.com wrote:

I have no idea what that version number is. Can you try with an official release from atom.io ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/noseglid/atom-build/issues/441#issuecomment-255167305, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRJ5shVJEtkJf7XEIKevH0yeGeaBlh2ks5q15_QgaJpZM4Izy8C .

javigf commented 7 years ago

I have this same issue with the update today to ver Atom : 1.12.0 Electron: 1.3.6 Chrome : 52.0.2743.82 Node : 6.3.0

Updated Chrome, rebooted, restarted... nothing seems to fix the issue image

And stays forever ...

noseglid commented 7 years ago

@javigf this was fixed and will be in the next version

thehellmaker commented 7 years ago

can we get an interim patch for this. I am blocked on this as well