added: non-file specific errors

noseglid / atom-build

:hammer: Build your project directly from the Atom editor

https://atom.io/packages/build

MIT License

248 stars 97 forks source link

added: non-file specific errors #465

Closed ProPuke closed 7 years ago

ProPuke commented 7 years ago

errorMatch and warningMatch may now catching a the file.

These errors will be grouped together, and displayed via an atom error notification popup (as Linter does not currently support displaying errors without file locations).

see #463

Cxarli commented 7 years ago

Fixed linter errors in https://github.com/ProPuke/atom-build/pull/1

noseglid commented 7 years ago

Joined with the answer in #463, I think this may not be the right way to go. I'm not comfortable with removing the requirement on filePath, and introducing yet another way to display errors will cause more confusion than it will actually help people I think.

Thanks for the proposal, but I must decline.