noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Allow copying text from build output #477

Closed AndiDog closed 7 years ago

AndiDog commented 7 years ago

Copying text out of the build output div isn't working right now (tested with Atom 1.10.2 on Mac OS X). Since no user-select override is used, I guess it must be because of the way core:copy is mapped to keys by Atom's default keymaps – Cmd+C doesn't trigger core:copy when selecting text in the output console. This change enables copying text.

noseglid commented 7 years ago

It's working well for me. (also Mac, and Atom 1.10.2). copy

Could there be something else interfering?

Edit: It's not supposed to trigger core:copy, but rather relay to the native keybindings as it is set on the build-view.

AndiDog commented 7 years ago

Interesting. For me, neither native! nor core:copy were triggered. I'll check back with all other packages disabled to find out why it doesn't work for me.

AndiDog commented 7 years ago

I cannot reproduce it anymore, so either it was resolved by an update of Atom, or just magically working. Nevermind - thank you!

noseglid commented 7 years ago

👍