search

noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Add `.yaml` as an alternative extension. #497

Closed jvhellemond closed 6 years ago

jvhellemond commented 7 years ago

According to YAML.org, the preferred extension for YAML files is .yaml. Of course, a lot of (most?) YAML files around the web have .yml extensions.

This simply adds the .yaml extension to the list of allowed config files as an alternative.

noseglid commented 7 years ago

Sorry for being so slow on this.

I'd be happy to add this functionality, but I'd like to see a test for it aswell. In essence just copy this test and change appropriately for yaml.

ShayBox commented 6 years ago

Don't wait for someone else to code such a simple task for you. This is your package, and you described exactly how to do the simple task.

noseglid commented 6 years ago

That's just it. It's not "for me". I have no interest in this functionality. But someone else does, and more might, so I'm willing to accept it.

ShayBox commented 6 years ago

The point of making this an open source repo is for people to post ideas and bugs, and for you to fix them, as well as anyone else that is able to contribute. This is not an excuse to not make new features and not fix bugs. If that's how you feel then you should probably just drop the package all together and wait for someone else that has the right mentality to fork it and pick it up.

oli-obk commented 6 years ago

These packages are not our dayjob. They are not even our part time jobs. If you feel so negatively about this package, you may fork it anytime and try to do better. Or you may contribute tho the package itself. But please refrain from downtalking the amazing work that @noseglid has done. He's been nothing but patient with my PRs and explained at great length how to improve them. This PR is just like that. If you feel like the PR deserves more attention, then feel free to take it over and finish it. Git makes this super easy. Open source developers are neither a free workforce nor do they owe anything to anyone. It's a free for all in its purest form.

Cxarli commented 6 years ago

If you all tell each other to do it, I guess I'll do it then.

I couldn't find out how to commit to this PR, so I did it seperately