search

noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Panel not showing on Sass compile error #499

Closed onetrev closed 7 years ago

onetrev commented 7 years ago

My apologies if I'm being a massive n00b right now, but as far as I can tell this is an issue. I have my Panel Visibility set to "Show on Error" but it does not show. If I open the panel (as attached image shows) there definitely is a sass compile error. And my gulp notify pops up as usual. However the panel definitely does not open automatically.

Accordingly, despite having Atom Linter running as usual, I also do not receive Atom Build errors in my linter panel. Which I'm assuming is very much related to the above issue.

Please let me know if there is anything I can do to troubleshoot this. Thanks!!

SYSTEM DETAILS: Atom 1.14.2 x64 Windows 10

snip_20170215183347

noseglid commented 7 years ago

The command is exiting with a zero exit status, thus atom-build does not detect the error. You need to add something that makes gulp exit with an error when a sass compile error is detected. Something like this.

There are no error matchers in build-gulp, unfortunately so you wont get linter errors. Feel free to implement and send a PR!

onetrev commented 7 years ago

Ahhhh, that makes sense. Thanks a ton for the super quick follow up!

Not sure I have the JS skills yet to successfully implement errors matchers in build-gulp, but I'll put that on a list of projects for practising my javascript.