search

noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Fix issue with incorrect path for text editor #501

Closed ivankravets closed 7 years ago

ivankravets commented 7 years ago

Atom >= 1.13 doesn't return a real path for textEditor.getPath(). In this case, affected projects will not be available for "build".

For example, project is located in /private/tmp/myproject

oli-obk commented 7 years ago

Hmm. This fails some oft our Tests... Maybe they need that change, too?

ivankravets commented 7 years ago

@oli-obk that is not a problem of this PR. See previous commits that also are failed.

oli-obk commented 7 years ago

Oh, I'll check it out

noseglid commented 7 years ago

I am sorry for being terribly slow on this.

The PR looks good. Would you mind rebasing on latest master where I've fixed the specs Turns out it's enough that I restart the CI builds.