search

noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Fix spelling: succeding -> succeeding #512

Closed jordiorlando closed 7 years ago

jordiorlando commented 7 years ago

I searched through several build providers to see if this would break anything, and I haven't yet found any uses of this hook, but this needs more extensive searching to be sure.

noseglid commented 7 years ago

I think @ivankravets is using it. Am I wrong?

ivankravets commented 7 years ago

We use preBuild/postBuild hooks. See https://github.com/platformio/platformio-atom-ide/blob/develop/lib/services/build.js#L258

jordiorlando commented 7 years ago

I just searched through every repository in the list of build providers and couldn't find anyone using it. The only place I found it on GitHub was in many users atom configuration repos (dotfiles), which shouldn't matter.

noseglid commented 7 years ago

This just changes the specs and an obvious spelling error. Would you mind rebasing on latest master where I've fixed the specs?

noseglid commented 7 years ago

Thanks!