search

noseglid / atom-build

:hammer: Build your project directly from the Atom editor
https://atom.io/packages/build
MIT License
248 stars 97 forks source link

Target Manager fails on Target Refresh with Atom 1.21.0 beta #541

Closed wendlers closed 6 years ago

wendlers commented 6 years ago

Hi,

today I tried my build providers (scons, mbed) with Atom 1.21.0 beta with build 0.68.0. For both, I get an exception when the build package comes to the point where it tries to refresh targets (see below). The issue could be trigered by adding a new project folder or by calling Build: Refresh Targets. I also tried with thebuild-make, same thing. I looked into the code, but it is not obvious to me what the problem is.

Also I know it might be too early to investigate that issue since 1.21.0 is still beta. Just though it might be good to be aware of this.

Regards, Stefan

Cannot read property 'split' of undefined
Hide Stack Trace
TypeError: Cannot read property 'split' of undefined
    at Object.humanizeEventName (/usr/share/atom-beta/resources/app/node_modules/underscore-plus/lib/underscore-plus.js:196:29)
    at extractDescriptor (/usr/share/atom-beta/resources/app/src/command-registry.js:447:74)
    at new SelectorBasedListener (/usr/share/atom-beta/resources/app/src/command-registry.js:414:29)
    at CommandRegistry.addSelectorBasedListener (/usr/share/atom-beta/resources/app/src/command-registry.js:163:36)
    at CommandRegistry.add (/usr/share/atom-beta/resources/app/src/command-registry.js:152:25)
    at /home/stefan/dev/atom-beta/packages/build/lib/target-manager.js:113:54
    at Array.forEach (native)
    at /home/stefan/dev/atom-beta/packages/build/lib/target-manager.js:108:18
wendlers commented 6 years ago

Oh, just realized, that this seams to be a duplicate of #532.

noseglid commented 6 years ago

dupe of #532

wendlers commented 6 years ago

Thanks for fixing. Works nicely now :-)