search

noseka1 / linuxband

GUI front-end for MMA (Musical MIDI Accompaniment)
linuxband.org
GNU General Public License v2.0
26 stars 15 forks source link

[PEP8] Cleanup white space, comments and semicola #24

Closed jensrudolf closed 4 years ago

jensrudolf commented 4 years ago

This commit introduces further cosmetic improvements by removing semicola from the end of some statements, ensuring at least to white spaces before an inline comment and deleting some unnecessary comments and linter hints. Additionally, it removes white spaces inside braces as well as brackets and adds the missing ones around some operators.

noseka1 commented 4 years ago

Great, thanks!

I didn't merge your changes in chord_table.py file. This file needs to be kept in sync with the chordtable.py file in the MMA's code base. That's why I don't want to make any changes to it.

jensrudolf commented 4 years ago

Hi @noseka1, thanks for the info. I will revert my changes to that file locally then in order to prevent them to appear in future pull requests.

FYI, I contacted Bob Mellowood, the maintainer of MMA, last December via email and suggested to move MMA development to some public vcs platform like e.g. GitHub to enable others to contribute to his software project. One of my ideas was to create a Python (wheel) package for MMA which then could be released on the Python Package Index. Then, other projects like Linuxband could reuse parts of MMA by importing its modules. This would remove the need to keep "files in sync". Bob was very open to that suggesting. In fact, he told me that he had already tried to move MMA into git some time ago but then somehow struggeled with it. But he promised me to take another attempt once he finds some time to work on this. I'll try to contact him again. Maybe this discussion can add to his motivation to work on this topic.

noseka1 commented 4 years ago

That's great to hear. A clean solution like the one you are suggesting would be nice to have.