noshluk2 / ros2_learners

This repository is for ROS2 future developers . This will support everyone to become a good developer .
MIT License
40 stars 14 forks source link

Updated errors for finding lib directories particularly for `rtabmap_ros`… #12

Closed amjad-haider closed 1 year ago

amjad-haider commented 1 year ago

This merge request updates the file generate_launch_description() with the following changes:

@@ -82,22 +82,22 @@ def generate_launch_description():
        # SLAM mode:
        Node(
            condition=UnlessCondition(localization),
-            package='rtabmap_slam', executable='rtabmap', output='screen',
+            package='rtabmap_ros', executable='rtabmap', output='screen',
            parameters=[parameters],
            remappings=remappings,
            arguments=['-d']), # This will delete the previous database (~/.ros/rtabmap.db)

        # Localization mode:
        Node(
            condition=IfCondition(localization),
-            package='rtabmap_slam', executable='rtabmap', output='screen',
+            package='rtabmap_ros', executable='rtabmap', output='screen',
            parameters=[parameters,
              {'Mem/IncrementalMemory':'False',
               'Mem/InitWMWithAllNodes':'True'}],
            remappings=remappings),

        Node(
-            package='rtabmap_viz', executable='rtabmap_viz', output='screen',
+            package='rtabmap_ros', executable='rtabmapviz', output='screen',
            parameters=[parameters],
            remappings=remappings),
    ])

The changes involve updating the package and executable names in the Node declarations. In the previous version, the package names were rtabmap_slam and rtabmap_viz, while the updated version uses rtabmap_ros and rtabmapviz respectively. This update aligns the code with the correct package naming convention.

Please review the changes and merge them if they are acceptable.

noshluk2 commented 1 year ago

Can you provide some explanation to changes ?

amjad-haider commented 1 year ago

I have updated the description. Kindly waiting for your feedback.