nosinovacao / name-sdk

A dependencies management library designed to expose and access dependencies information.
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Startup healthcheck should be async when ThrowOnDependenciesFail is false #4

Closed suvl closed 6 years ago

suvl commented 7 years ago

As of now, the startup healthcheck is always synchronous. As a result, when there are unreachable dependencies and/or dependencies without NAME installed (or any other unresponsive situation from the dependencies) at various levels, the application might take up to 20 seconds to start (max. timeout for the startup healthcheck as of now).

When ThrowOnDependenciesFail is false, that wait is not necessary at all and is indeed detrimental to NAME acceptance and roll-out.

Changes