nosiu / comfyui-instantId-faceswap

Implementation of faceswap based on InstantID for ComfyUI.
Apache License 2.0
176 stars 14 forks source link

Black space where face should be #25

Open pr1ntr opened 4 months ago

pr1ntr commented 4 months ago

So this is what I get. I remember having this issue with automaticwebui something to do with xformers.. i don't remember now though. Any ideas?

image

pr1ntr commented 4 months ago

if i set --windows-standalone-build --fp32-vae image

--windows-standalone-build --fp32-vae --disable-cuda-malloc image

nosiu commented 4 months ago

It hasn't been tested with turbo models You are using LCM Lora and turbo model which is a very bad combo. Also, you are resizing the face to 1024px, so it will try to generate something quite big 1024x~512 (guessing based on the aspect ratio of the mask), and turbo models usually can generate images no larger than 512x512

anyshu commented 4 months ago

same issue. black mask cannot be removed.

pr1ntr commented 4 months ago

i did figure out the black mask thing ended up with these flags --fp32-vae --disable-cuda-malloc for the bad quality it became pretty clear what the issue was @nosiu, wrong model and i think my workflow got messed up because once i reloaded with the LCM Lora it was good.

claireliu14 commented 4 months ago

I got same problem .. My comfyui is a version that supports CUDA121, but when executing instantid-faceswap, it will ask to use cuda 11, so I tried to install cuda 11.8 toolkit, but not used (If I change to cuda 11.8, comfyui while get error in ksampler). Could it be related to this? Screenshot 2024-02-21 at 11 06 34 AM

nosiu commented 4 months ago

@claireliu14 try to run comfy with --fp32-vae argument, Console should say

VAE dtype: torch.float32
deepfree2023 commented 4 months ago

Tested several models, all normal models without lcm,turbo, dpo, etc., some worked well, some only produced black mask in the final result but the preview image was correct. Don't know why... with lcm lora enabled or not didn't affect the result.

matabear-wyx commented 4 months ago

Tested several models, all normal models without lcm,turbo, dpo, etc., some worked well, some only produced black mask in the final result but the preview image was correct. Don't know why... with lcm lora enabled or not didn't affect the result.

@deepfree2023 Could u please share the models that worked well?

deepfree2023 commented 4 months ago

Tested several models, all normal models without lcm,turbo, dpo, etc., some worked well, some only produced black mask in the final result but the preview image was correct. Don't know why... with lcm lora enabled or not didn't affect the result.

@deepfree2023 Could u please share the models that worked well?

Sure, realvisXLV40, animaPencilXL_v150, albedoBaseXL_v21, dynavisionXL

liyunfei54 commented 3 months ago

测试了几个型号,都是没有lcm、turbo、dpo等的普通型号,有些效果很好,有些在最终结果中只产生了黑色蒙版,但预览图像是正确的。不知道为什么...... lcm lora 启用与否并没有影响结果。

@deepfree2023您能分享一下效果很好的模型吗?

当然,realvisXLV40、animaPencilXL_v150、albedoBaseXL_v21、dynavisionXL

thanks

longmans commented 2 months ago

It seems not stable, it crashs sometimes.