Publish to puppet forge?

ChristianHirsch commented 8 years ago

@tosmi , I wanted to ask you whether there is a specific reason why you did not publish your module to the puppet forge?

tosmi commented 8 years ago

only -ENOTIME. i'll promise to look into that within the next week. it's not going to be perfect, but with your changes it should be usable. better something than nothing :-)

tosmi commented 8 years ago

so, after a lot of rewriting i think i've got something publishable in the forge branch. it's testet under centos 7 as i've got not debian test systems. could you take a look at the code and eventually fix debian bugs?

i've split the service part into debian.pp and redhat.pp. redhat uses a custom reaktor systemd service.
notification is disabled per default, if a notifiers is enabled i use a second environment file for the config
the pid file is now under /run/reaktor
logs are in /opt/reaktor/log
and various other configs in /opt/reaktor/etc

let me know what you think. hopefully we've got our first release soon. i'll try to use the module with our internal reaktor installation asap. we use a modified reaktor version, so the presure of bringing the changes upstream rises :-)

thanks again for your hard work

tosmi commented 8 years ago

did you get a chance to look at the forge branch? i would like to merge this into master and publish a first release.

ChristianHirsch commented 8 years ago

@tosmi as far as I know it also works under ubuntu. colleagues tested it because I couldn't. one of the colleague will also give some feedback :)

ChristianHirsch commented 8 years ago

@tosmi: btw., the colleague who tested it is @bentobex

tosmi commented 8 years ago

ok, thanks. i'm going to merge the forge branch into master soon. will try to release to forge asap. if there are bugs (i'm sure there will be many :-)), we can always release a new version.

nosolutions / puppet-reaktor

Publish to puppet forge? #7