search

nosolutions / puppet-tsm

Install and manage TSM (Tivoli Storage Manager) client with puppet
GNU General Public License v3.0
13 stars 21 forks source link

add inclexcl.hiera hash (like config_hash) so we can manage inclexcl entries via hiera #16

Closed tosmi closed 7 years ago

bschonec commented 7 years ago

@tosmi , have you made the code changes or pull request for this? I'm about to do the same but don't want to duplicate efforts.

tosmi commented 7 years ago

no, this is currently not implemented. a pull request would be great. please also add some rspec tests for this.

thanks toni

bschonec commented 7 years ago

@tosmi Well, I know nothing (yet) about writing tests. I can't even get the master branch to pass the existing tests, let alone anything I may add. Would you be so kind as to fork the master and give it a TravisCI runthrough?

tosmi commented 7 years ago

i'll look into that tomorrow. we can work on the test together, just try to fork the repo, create a feature branch (e.g. inclexclhiera) and play around with the tests.

how did you try to run the tests?

bschonec commented 7 years ago

I'll work on that this week. I did finally get the existing tests to succeed on my server. It's writing new tests that confound me. I'm not a developer by any stretch.

bschonec commented 7 years ago

I hope I don't make too much of a fool of myself for #46

tosmi commented 7 years ago

thank for the pr. i'm going to look into it over the next days.