search

nosoop / SM-TFAttributeSupport

A SourceMod plugin that improves support for official TF2 attributes.
GNU General Public License v3.0
12 stars 4 forks source link

"Use Large Smoke Explosion" does not affect manually detonated Stickybombs #10

Closed SoulBlast35 closed 11 months ago

SoulBlast35 commented 2 years ago

Never noticed this before because Ive only done this on Robot Demomen, who never manually detonate, but the giant smoke blast only occurs if the Stickybomb(s) detonate if they are forced to from going over the set limit for the Launcher being used. Quite low priority, but just something I thought I'd note.

nosoop commented 2 years ago

Yeah, that's a really weird case. They both run the same code path and should be able to use the large smoke explosions, but for some reason the DispatchParticleEffect only renders on one and not the other.

I have a fix for this all ready to go, but DHooks just isn't playing nice as usual.

Feel free to compile the referenced commit below if you'd like to try it out. It's known to conflict with having the Starter Pack loaded in.

SoulBlast35 commented 2 years ago

Doesnt seem to be working for me, Server hard-crashes upon detonating a smokebomb sticky. Its not high priority though and I kinda like using the Starter Pack a lot. Speaking of that, found an oddity with it that I submitted an issue for

nosoop commented 2 years ago

Yeah, the hard crashing is the DHooks not playing nice as usual. Plugin-based virtual hooks are an absolute mess.