search

nosoop / SM-TFAttributeSupport

A SourceMod plugin that improves support for official TF2 attributes.
GNU General Public License v3.0
12 stars 4 forks source link

Explosive Gas Passer Bug(?) #2

Open SoulBlast35 opened 3 years ago

SoulBlast35 commented 3 years ago

Applying the "explode_on_ignite" attribute to a weapon you set to launch Gas Passer cans doesnt seem to work. In contrast, "applies snare effect" works fine on weapons that are set to fire Jarate and Mad Milk projectiles, and this even works on the Gas Passer itself, but the explode on ignite attribute just doesnt work.

nosoop commented 3 years ago

If I'm reading it correctly, a quick skim of the Linux decompile indicates that the code path only runs on the secondary item. There's also an additional check that the secondary item has the TF_WEAPON_JAR_GAS weapon ID. It's not quite simple to patch the game code directly in that instance, but it is doable in theory. The alternative would be to recreate the explosion code in-plugin.

I'll leave this issue open since it's a valid one and in the scope of the project, but I don't believe I'll be handling this case at this time; maybe in the future. PRs are also welcome if you're interested in tackling this yourself.

SoulBlast35 commented 3 years ago

I pretty much have zero knowledge of SourcePawn and even less so of Linux. The most I've done is a very small edit to Deathreus's "Be the Giant" plugin where I swapped the attribute "move speed bonus" with "move speed penalty" so it didnt conflict with MvM Upgrades.