search

nosoop / SM-TFAttributeSupport

A SourceMod plugin that improves support for official TF2 attributes.
GNU General Public License v3.0
12 stars 4 forks source link

Add workaround for global hook conflicts #20

Closed M60TM closed 1 year ago

M60TM commented 1 year ago

I think we can revert Preemptively avoid DHooks gameconf overlaps. I forgot to say I add g_SavedMeter null check. It will be fix all the meter's malfuction.(e.g. bonk atomic drink and sandvich won't recharge after first use)

nosoop commented 1 year ago

Thanks for the contribution!

I think we can revert Preemptively avoid DHooks gameconf overlaps.

That would break gamedata compatibility (aside from the short-lived a950a0e9cf1d43df699d6ae7d6be04aef161555c that should've not been issued a release), so I'd opt to keep it. I really value being able to use updated gamedata with previous versions of plugins.

The rest of it looks good, though to ensure readable commit history, if you can rebase / squash it down to two commits (one for the change involving global hook conflict mitigation and another for the g_SavedMeter check) that would be appreciated. I'll try to get that done this weekend if you don't get around to it yourself (or can't, since you PR'd your main branch).