nosoop / SM-TFCustomAttributeStarterPack

A collection of plugins to be used with the TF2 Custom Attribute framework.
MIT License
19 stars 10 forks source link

After latest update, CGlobalEntityList::FindEntityInSphere() has incorrect signature #77

Closed higps closed 1 year ago

higps commented 1 year ago

The signature

        "CGlobalEntityList::FindEntityInSphere"
        {
            "library"   "server"
            "windows"   "\x55\x8B\xEC\x83\xEC\x0C\x53\x56\x57\x8B\xF9\x8B\x4D\x2A"
            "linux"     "@_ZN17CGlobalEntityList18FindEntityInSphereEP11CBaseEntityRK6Vectorf"
        }

Is no longer correct and causes crashes or plugin to simply not load.

higps commented 1 year ago

This appears to be linux only, as windows seems to work

naydef commented 1 year ago

Seems to affect Windows, too.

Crash: https://crash.limetech.org/3si5xkxbxxte

nosoop commented 1 year ago

Linux should be _ZN17CGlobalEntityList18FindEntityInSphereEP11CBaseEntityRK6VectorfP17IEntityFindFilter, with the new parameter. Thanks; will update momentarily.

nosoop commented 1 year ago

Windows signature is unchanged, though plugins will need to fix their SDKCalls to pass NULL in as the last parameter.

Note that the Windows signature you've posted differs from the one in the repository.