Feature/codacy coverage

[codecov[bot]]

Codecov Report

Merging #499 into develop will decrease coverage by 0.45%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #499      +/-   ##
===========================================
- Coverage    93.71%   93.26%   -0.46%     
===========================================
  Files          229      228       -1     
  Lines         7000     6932      -68     
===========================================
- Hits          6560     6465      -95     
- Misses         440      467      +27

Impacted Files	Coverage Δ
app/controllers/dns_records_controller.rb	98.11% <ø> (ø)	:arrow_up:
app/models/dns_hosted_zone.rb	73.23% <ø> (+2.57%)	:arrow_up:
app/controllers/communities_controller.rb	86.3% <100%> (ø)	:arrow_up:
app/controllers/convert_donations_controller.rb	95.83% <100%> (+0.83%)	:arrow_up:
app/services/donation_service.rb	27.41% <0%> (-47.21%)	:arrow_down:
app/models/donation.rb	52.5% <0%> (-6.1%)	:arrow_down:
spec/support/blueprints.rb	98.29% <0%> (-0.13%)	:arrow_down:
spec/services/donation_service_spec.rb	100% <0%> (ø)	:arrow_up:
spec/factories/activists.rb	100% <0%> (ø)	:arrow_up:
spec/models/donation_spec.rb	100% <0%> (ø)	:arrow_up:
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44ad4cb...ea60371. Read the comment docs.

[hudsilva]

Adicionado a % de coverage do codacy no readme https://github.com/nossas/bonde-server/tree/feature/codacy_coverage

app/controllers/convert_donations_controller.rb criado método privado para pegar o Widget através do model app/controllers/notifications_controller.rb criado método privado para pegar a Notification através do model app/models/dns_hosted_zone.rb removido método não utilizado, passível de falhas de SQL app/controllers/communities_controller.rb e app/controllers/dns_records_controller.rb removidos espaços em brancos

Os arquivos app/controllers/activists_controller.rb app/controllers/convert_donations_controller.rb Já possuíam métodos privados em seu contexto.

config/initializers/secret_token.rb removido por questões de segurança. Token da app configurado via string direta nesse arquivo.

[lpirola]

@hudsama o que falta ainda para esse PR ser mergeado?

[hudsilva]

@lpirola já foi finalizado.