search

nostalgia-dev / nostalgia

Utilize your personal data like Google!
163 stars 10 forks source link

Darksky weather api enricher #24

Closed kootenpv closed 4 years ago

kootenpv commented 4 years ago

The goal is to enable adding historic data. Not a lot of APIs offer (free) historical data for any location. But Darksky offers 1000 calls per day. And in this call, you get hourly data (so 24 of them). This is good enough granularity I believe.

In my case, to backfill all my data, I need 4 days.

Would still be nice to be able to easily schedule.

Also, need to think of a way to not make enrichers add to data, but enable some kind of virtual data that can be joined on.

kootenpv commented 4 years ago

@jjc385 True, it's a bad description, not sure where my head was.

When we squash we should make sure it mentions it also adds iterate_time and its functionality (namely, returning a single row for an evenly space timed).

NickolayVasilishin commented 4 years ago

Looks pretty good.

Also, I really like the description/ discussion. Though I think the commit message leaves a little to be desired. Maybe "Add basics of Darksky weather api enricher" would be better? Then probably "targets #4" in the message body.

But you will squash all your commits here in github ui, so then you put here a meaningful commit message summary So it doesn't really matter what you write in git messages, but it can just help you not rewriting everything on squash

kootenpv commented 4 years ago

I also added a function that simply returns the data per hour of a day.

kootenpv commented 4 years ago

Too bad it did not detect the review was succesful on the earlier commit