search

nostalgia-dev / nostalgia_chrome

Self tracking your browser history!
20 stars 4 forks source link

Options #12

Closed Ryuno-Ki closed 4 years ago

Ryuno-Ki commented 4 years ago

This PR is wrapping the existing scripts in IIFE, to allow for shared values, which can then be updated via a preference page.

I can add docstrings to options.js, but would like to try this out on mobile first.

My hope is, that I can use Remote Debugging to load the extension on Android. Firefox shows a screenshot listing extensions.

So perhaps you want to wait until I could test it.

kootenpv commented 4 years ago

Sorry for creating a conflict by accepting the other...

Ryuno-Ki commented 4 years ago

I almost expected this to happen. Lemme fix it.

kootenpv commented 4 years ago

Hmm weird, I did get the options to pop up, but not reliably. Isn't it supposed to pop up when we click Nostalgia icon?

EDIT: it happens with the options page where it pops up. So it's working well!