nostalgia-dev / nostalgia_chrome

Self tracking your browser history!
20 stars 4 forks source link

Update to Manifest version 3 Fixes #13 #14

Closed Ryuno-Ki closed 10 months ago

Ryuno-Ki commented 11 months ago

I've good news and bad news for you.

The good news: I was able to port the code to the Manifest Version 3 (breaking change. I've bumped the version).

Bad news: It doesn't work like this in Firefox. Bugzilla issue

You would need to swap out background.service_worker for background.scripts (and put the JS path in an Array) to submit it to Firefox.

As a cherry on top I've implemented an options page :cat:

kootenpv commented 10 months ago

Amazing my dude! I am still using it every day so I would have been lost without you on this breaking change 😬

Will this V3 already work? If so, I'll give it a try.

Also, I noticed I'm storing duplicate data: I guess event on page load triggers twice somehow, not sure if you experience the same?

Ryuno-Ki commented 10 months ago

Hey there,

I keep my promises :cat:

Yes, it is working for me. Notice that Firefox needs a slightly different manifest.

I can imagine, that you are recording once for when the index.html finishes loading and another time for SPA changes (History API updates).

kootenpv commented 10 months ago

Awesome! I tested all the functionality and everything works, so nice!!

kootenpv commented 10 months ago

I'm curious which data you track? videoswatched as well? or mostly just interested in the web visits?

Ryuno-Ki commented 10 months ago

Given the tracking, I'm watching videos using Invidious myself.

So, yes, only visited websites.