search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

Dark mode for checkbox #255

Closed in-in closed 5 years ago

in-in commented 5 years ago

Describe the bug The checkbox loses visibility when it is inside a dark container v-2019-01-18_23 16 51

To Reproduce

  1. Go to https://nostalgic-css.github.io/NES.css/
  2. Add is-dark class to container with checkbox
  3. Try check/uncheck this checkbox 190181547843296

Expected behavior

<input type="checkbox" checked="" class="nes-checkbox is-dark">

I was expecting a light mark when I added the is-dark class to input

Screenshots see above :point_up:

Environment:

Ilyeo commented 5 years ago

Hello, @guastallaigor #263 this PR has the fix for this issue. Could you take a look, please? let me know if you want to change something...

guastallaigor commented 5 years ago

Hello @Ilyeo, I'm going to be busy at work but I can take a look when I get back home. Thank you for your contribution.

BcRikko commented 5 years ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: