search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

[#250] Fix border bugs #261

Closed BcRikko closed 5 years ago

BcRikko commented 5 years ago

borders does not working on firefox

fix #250 fix #238

Description

nes-btn, nes-input, etc...

SVG fill did not working on FireFix.

So I fixed HEX to RGB.

firefox safari chrome
2019-01-29 17 00 28 2019-01-29 17 01 15 2019-01-29 17 01 34

nes-container.is-dark

Border did not working when in dark mode.

before after
2019-01-29 17 34 40 2019-01-29 17 34 59

Compatibility N/A

Caveats

BcRikko commented 5 years ago

Thanks for reviewing 🙇 I'll merge this PR. 👍

BcRikko commented 5 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: