[#255] Dark mode for checkbox

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.61k stars 1.65k forks source link

[#255] Dark mode for checkbox #263

Closed Ilyeo closed 5 years ago

Ilyeo commented 5 years ago

Fix: #255

Description

We need to add styles when the checkbox is on dark mode, currently, the checkbox is not visible at all if the container is dark.

Compatibility

Now we can to add the class is-dark to a nes-checkbox element.

Caveats

Not yet.

Ilyeo commented 5 years ago

Hey, @guastallaigor, I added the is-dark class to the storybook, now I'm just waiting to #264 will merge, after that, I will changes that @BcRikko said

Ilyeo commented 5 years ago

@BcRikko @guastallaigor I think is ready to go, folks, what do you think?

BcRikko commented 5 years ago

@Ilyeo Thanks 😆👍

BcRikko commented 5 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: