fix(dialog): fix dialogs is-dark white border missing.

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.61k stars 1.65k forks source link

fix(dialog): fix dialogs is-dark white border missing. #280

Closed guastallaigor closed 5 years ago

guastallaigor commented 5 years ago

ref #281.

Description This PR fix the is-dark dialog white border, because it don't have an after like the Container component.

Before this PR:

After this PR:

Compatibility N/A

Caveats N/A

guastallaigor commented 5 years ago

nes-dialog is an old implementation. Could you use @include rounded-corners(); instead of border like nes-container.

I'm sorry but I could not understand.

Containers.scss - is-dark

Dialogs.scss - is-dark

As you can see they're basically the same implementation. When just is-dark is set, without is-rounded, they're both using border, and not rounded-corners, because it's not rounded, it's squared by default. Could you be more specific?

BcRikko commented 5 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: