search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

Feat/add coin icon #283

Closed sombreroEnPuntas closed 5 years ago

sombreroEnPuntas commented 5 years ago

Motivation

I loved the project, and used it recently to pimp a coding challenge (car-gallery).

I realized that there are currently no coins on the icon collection, so I made one.

I also wanted to use this icon to gamify (is that even a word?) the UX, so when the user gives a valid input the form drops him/her a coin :moneybag:. So I made that one too.

<3

Description

Solves #282 feature request by adding nes-coin and earned css classes. Check it out on storybook app.

Compatibility

No breaking changes.

Caveats

None.

Comments

I had to restrain myself from sorting imports/exports alphabetically. IMO this improves DX and helps a lot when reading diffs :)

Sort all of the things!

sombreroEnPuntas commented 5 years ago

All changes are done :)

PS: srry, for the force push. The suggest edit feat on github web UI is not working awesome yet... Only made the commit on this PR, but somehow was not added to the source repo :o

BcRikko commented 5 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: