search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

Renew demo site #292

Closed BcRikko closed 5 years ago

BcRikko commented 5 years ago

Description Recreate the demo site for easy maintenance.

Compatibility not

Caveats new-demo

BcRikko commented 5 years ago

I deleted the blur filter and added notes. 2019-02-24 10 11 13

BcRikko commented 5 years ago

These are the result of analyzing with localhost. I think that if we host on github pages Performance and Best practice will go up. 🚀 To improve accessibility, we have to change the color of NES.css. 😅 We don't need a PWA.

before after
2019-02-25 21 14 05 after_audit
2019-02-25 21 14 31 after_performance
BcRikko commented 5 years ago

The 8-bit cursor isn't working for me anymore, even if I import the css locally. Not sure if I'm missing something.

sry, I don't know... 🤔 There was no problem in my environment.　Could you check once more?

guastallaigor commented 5 years ago

@BcRikko Can I make one small commit instead of asking you to change it in the ballon and button? Maybe it's better if I make another review and give you the code.

BcRikko commented 5 years ago

What kind of change is it? 🤔 Could you upload screen capture? 📷

BcRikko commented 5 years ago

When I click on it, and try to scroll down, it "locks" me there, even if I click in the scroll bar. To fix it I had to hold the mouse button down on top of the scroll bar and then drag it down.

I'll fix it 🛠 When catching the scroll event, it will cancel the toTop

    toTop() {
      const scrolling = setInterval(() => {
        if (window.scrollY > 0) {
          window.scrollBy(0, -window.scrollY / 10);
        } else {
          clearInterval(scrolling);
        }
      }, 10)
BcRikko commented 5 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: