nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

Bug: Highlight.js not loading sometimes in index.html (docs) #293

Closed guastallaigor closed 5 years ago

guastallaigor commented 5 years ago

Describe the bug Sometimes when opening the documentation demo website, there's no style in the code div.

To Reproduce Steps to reproduce the behavior:

  1. Open documentation demo website;
  2. Click on the "show code button";
  3. You will see that sometimes the code div has no style at all;
  4. You can also check chrome devtools console that appears a hljs is not defined.

Expected behavior Everytime the page is opened highlight.js should be loaded.

image

Screenshots image

Environment:

Suggestion(s) for fixing this issue Change the <script> tag or maybe put the hljs init inside window.onload.

Additional context This could be a hotfix situation.

BcRikko commented 5 years ago

I see 🙈 I fixed it in #292 .

BcRikko commented 5 years ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: