search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.61k stars 1.65k forks source link

Fix a Chinese typo #300

Closed sinofp closed 5 years ago

sinofp commented 5 years ago

Description

fix(readme-zh-ch.md): fix chinese typo 或者按照如下方式简单引人 -> 或者按照如下方式简单引入

Compatibility

Not breaking.

Caveats

Nope.

BcRikko commented 5 years ago

Thanks 🙇 Could you fix your commit message? 🤔

I think commitlint will pass if you modify commit message as follows.

- Fix Chinese typo in README-zh-CN.md
+ fix(readme-zh-ch.md): fix chinese typo
sinofp commented 5 years ago

Thanks Could you fix your commit message?

I think commitlint will pass if you modify commit message as follows.

- Fix Chinese typo in README-zh-CN.md
+ fix(readme-zh-ch.md): fix chinese typo

You're welcome!😊 So should I redo this fix in a new commit with your message, and create a new pull request for that commit? I can't find a way to change the commit massage in this pull request…

BcRikko commented 5 years ago

I want you to try it 👍 

# edit your commit message
$ git commit --amend -m "fix(readme-zh-ch.md): fix chinese typo"

# force push branch
$ git push --force-with-lease origin patch-1

If you can not do it, could you recreate pull request? 🙏

sinofp commented 5 years ago

I want you to try it +1

# edit your commit message
$ git commit --amend -m "fix(readme-zh-ch.md): fix chinese typo"

# force push branch
$ git push --force-with-lease origin patch-1

If you can not do it, could you recreate pull request? pray

Wow, amazing command! Thank you for your help, now I have passed the test!

Airkm commented 5 years ago

I don't use this? Please ignore me.

BcRikko commented 5 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: