Tip of wing should technically be wing color

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.56k stars 1.64k forks source link

Tip of wing should technically be wing color #332

Closed zhammer closed 5 years ago

zhammer commented 5 years ago

Not 0 (default pixel color)

Description It does not do much

Compatibility Not breaking

Caveats I just think this is funny, not super important to fix since the background should default to white anyway.

BcRikko commented 5 years ago

Thanks. LGTM 👍

But this PR has commitlint error. Could you change your commit message? 🤔

# edit your commit message
$ git commit --amend -m "fix: tip of wing should technically be wing color "

# force push branch
$ git push --force-with-lease origin patch-1

BcRikko commented 5 years ago

ref #349

Thank you for your PR, but I will close it. 🙇🙇🙇