Closed kyu-suke closed 5 years ago
Thanks for your pull request. π
I'm concerned about accessibility. π€
visibility: hidden |
visibility: visible |
---|---|
![]() |
![]() |
If specify visibility: hidden;
, radios and checkboxes will be removed from the accessibility tree.
I don't know much about accessibility, so I can't think of any other good idea. π
Do you have other good ideas? π€
@BcRikko
Thanks for your review!!
oh..
You are correct!
I confirmed that radio that is set visibility: none
is not focused by tab π
I found some ways about hiding input without accessibility loss.
I will try these.
If it will be success, I push to this pr π
@BcRikko
I updated!
Description
view
accesibillity
There may be points I have missed. If you have any opinion please.
thanks!
:tada: This PR is included in version 2.2.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Description I updated radio and checkbox style in iOS.
-webkit-appearance: none
seems not to work in iOS. So I addedvisibility: none;
checkbox![checkbox](https://user-images.githubusercontent.com/9162117/60283448-1c1d0300-9944-11e9-8f35-8743b26e984f.png)
radio![radio](https://user-images.githubusercontent.com/9162117/60283449-1cb59980-9944-11e9-8f01-fb9558abcfff.png)
ref https://github.com/nostalgic-css/NES.css/issues/8
Thanks for your review π