nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.49k stars 1.64k forks source link

String interpolation to calculate width of inputs. Fix #322 #364

Closed thisisabhinay closed 4 years ago

thisisabhinay commented 4 years ago

Description

This PR resolves the issue #322 in which form inputs are bleeding out of parent container. This problem is solved by subtracting the width of both left and right borders from the total width of input element.

The solution:

Compatibility

This PR is not breaking any compatibility.

close #322

thisisabhinay commented 4 years ago

Can you please explain how to pass this test? @guastallaigor

Screenshot 2019-10-10 at 7 27 14 AM
BcRikko commented 4 years ago

This error is commitlint error. Could you change your commit message to something like fix: string interpolation to calculate width of inputs 🙇

The git commands shoud be something like this:

# edit your commit message
$ git commit --amend -m "fix: string interpolation to calculate width of inputs"

# force push branch
$ git push --force-with-lease origin issues/nes-bleeding-form-inputs
BcRikko commented 4 years ago

Sorry, I couldn't tell you exactly. 😢 Commit messages must be all lowercase.

- Fix: String interpolation to calculate width of inputs
+ fix: String interpolation to calculate width of inputs
thisisabhinay commented 4 years ago

@BcRikko Fixed lint issues with commit message.

BcRikko commented 4 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: