nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.49k stars 1.64k forks source link

Select `is-dark` is Missing States #384

Closed HiKaylum closed 4 years ago

HiKaylum commented 4 years ago

Describe the bug The select component is missing the states is-error, is-warning & is-success when is-dark.

To Reproduce

  1. Add
    <div class="nes-select is-dark">
    <select required>
        <option value="" disabled selected hidden>Select...</option>
        <option value="0">To be</option>
        <option value="1">Not to be</option>
    </select>
    </div>
  2. Try add a class is-error, is-warning or is-success

Expected behavior Select should show select state when is-dark.

Screenshots N/A

Environment: N/A

Suggestion(s) for fixing this issue N/A

Additional context N/A

HiKaylum commented 4 years ago

Found the issue, have a fix will wait till #385 goes through.

HiKaylum commented 4 years ago

Reopening, Closed it and the PR due to confusion.