feat(icon): Add about.me icon

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.47k stars 1.64k forks source link

feat(icon): Add about.me icon #417

Open candywater opened 4 years ago

candywater commented 4 years ago

Description This is a icon about https://about.me

Icon idea is from https://about.me/favicon.ico It only shows "me" as tab icon in firefox. Annotation 2020-05-02 021104

Compatibility It seems fine with compatibility.

Caveats important: after merging, update document, please. I should also add this icon to update the document, but i did not add it. Because I found that document use the following css file, if I add icon to document, it would break document. https://unpkg.com/nes.css@latest/css/nes.min.css

candywater commented 4 years ago

sorry for again and again force push.... only to change commit message to fit commitlint. I have changed commit message for several times, but it still cannot pass commitlint test.... But it seems work fine in my local environment. This is my first time to use commitlint, I cannot figure out how to solve it.

2020-05-05 23_11_44-Window 2020-05-05 23_09_10-Window

I read #413 and #415, understood situation.....

trezy commented 4 years ago

Don’t worry @candywater, this is actually an issue with our CI, not your PR. We’re investigating the issue in #415.

guastallaigor commented 4 years ago

As much as I would like this icon, I don't have authorization to merge any new icons. References:

So we will need to wait for the creator in this one. I will make a new PR to all README.md regarding this. I do apologize for the delay.

candywater commented 4 years ago

Thanks for your mention! @guastallaigor I have read #310 , too. I understood the situation, maybe NES-icons.css is a much better idea. and here are the images