fix(badge): rename is-splited to is-split

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.64k stars 1.65k forks source link

fix(badge): rename is-splited to is-split #422

Closed ldd closed 4 years ago

ldd commented 4 years ago

Description Rename is-splited to is-split. First of all, splited is not an English word, splitted is archaic and is-split is the correct usage

Compatibility This pull request is relatively minor, clean, and only changes 3 files. So it shouldn't break anything.

guastallaigor commented 4 years ago

@ldd Thank you for your PR. However, I don't think I can merge this without authorization from the creator, since this is a breaking change that will affect other repositories that are currently using this as is-splited. But I see your point that the word is wrong, so I will leave this open for him to review it when he can.

ldd commented 4 years ago

Thanks! On the other hand, maybe a deprecation warning makes more sense:

do not remove 'is-splitted', but instead, offer a warning.
add 'is-split' as an alternative to 'is-splitted'.

I think that has better chances of being approved, what do you think?

guastallaigor commented 4 years ago

Nice idea, I agree, this makes more sense. I'm sorry but if you can't wait a bit more until this PR is merged #424 After that, you can change it to make both work, and then I merge it. Thank you.

ldd commented 4 years ago

cool. cool cool cool.

guastallaigor commented 4 years ago

Hello @ldd, when you get a chance you can make the changes we discussed before, or just let me know if I can push to your branch so I can do it for you :+1: Thank you.

ldd commented 4 years ago

Changes are done! Let me know if you need anything else.