search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.47k stars 1.64k forks source link

ci: change base image to fix commitlint error #426

Closed SecretBase closed 4 years ago

SecretBase commented 4 years ago

Reopen the PR. Sorry for the noise.

https://github.com/nostalgic-css/NES.css/pull/424

@virtuoushub @guastallaigor

instead of waiting for the upstream image updated. I decide to spend some time to run my own image. So others everyone can moving forward.

I fork the upstream base image and make some changes same as @virtuoushub opened PR for the upstream.

https://github.com/SecretBase/circleci-commitlint-step https://hub.docker.com/r/secretbase/circleci-commitlint/tags

SecretBase commented 4 years ago

@virtuoushub OMG it work. 😭

Thank you everyone effort. Hope this can getting merge soon

virtuoushub commented 4 years ago

@SecretBase great job! Thanks for taking the initiative on publishing the new docker image. Hope you do not mind, I incorporated this PR into #418 ( https://github.com/nostalgic-css/NES.css/pull/418/files#diff-1d37e48f9ceff6d8030570cd36286a61R17-R20 ) to get the commitlint step to pass there.

SecretBase commented 4 years ago

@SecretBase great job! Thanks for taking the initiative on publishing the new docker image. Hope you do not mind, I incorporated this PR into #418 ( https://github.com/nostalgic-css/NES.css/pull/418/files#diff-1d37e48f9ceff6d8030570cd36286a61R17-R20 ) to get the commitlint step to pass there.

No problem. I close mine