search

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク
https://nostalgic-css.github.io/NES.css/
MIT License
20.64k stars 1.65k forks source link

fix(rounded-corners): fix chrome border image repeat #438

Closed stanleynguyen closed 3 years ago

stanleynguyen commented 4 years ago

Description Resolves #434

Compatibility

Backward-compatible

Caveats

stanleynguyen commented 3 years ago

Thank you for your contribution. However, I tested using Storybook and Chrome Version 85.0.4183.121 (Official Build) (64-bit), and without this the borders is a lot worse in some resolutions / zooms.

With border-image-repeat: space

image

Without border-image-repeat: space

image

This means it's not perfect, but in my opinion it's better with border-image-repeat: space than without. Could you share your environment, the tests that you've made and your opinion or some screenshots regarding this? Thank you.

Thanks @guastallaigor for the feedback. I only checked on my Mac Air (13 & 11 inch) and didn't realise these issue above 🤔 Guess this is a more complicated problem than it seemed