fix(button): Remove extra space caused by input type="file"

nostalgic-css / NES.css

NES-style CSS Framework | ファミコン風CSSフレームワーク

https://nostalgic-css.github.io/NES.css/

MIT License

20.47k stars 1.64k forks source link

fix(button): Remove extra space caused by input type="file" #471

Closed andreadellacorte closed 2 years ago

andreadellacorte commented 2 years ago

Description Currently, elements have opacity: 0 rather than display: none - This is causing them to actually take space, causing an issue on mobile where the expands to the right.

This change fixes that.

Compatibility No

Caveats None

trezy commented 2 years ago

Thanks for the contribution! You'll need to update your commit message to comply with conventional commits before the checks will pass.

Also, did you verify that the file input still works on all devices after making this change? From what I recall, the input is set to opacity: 0 because it still needs to be clickable. Setting it to display: none; would theoretically leave us with a pretty but non-functional component.