nostr-connect / nostrum

iOS & Android reference implementation of a Nostr Connect NIP-46 remote signer. Written with React Native Expo
MIT License
61 stars 4 forks source link

Create github release #17

Closed allanbowe closed 1 year ago

allanbowe commented 1 year ago

It would be great if your build process could create an automatic github release of your apk (with SHA checksums)

This would enable auto-discover in tools such as Obtainium

fyi the android build is not currently available at all it seems, the expo link returns this:

<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
<Details>No such object: turtle-v2-artifacts/production/c0f35709-4281-4f0e-a2a1-d02f47d00bf9/80ba55f5-88eb-4596-9ea5-386f0f7a4808/application-c044bec4-014c-4ea7-b625-69c556a28155.apk</Details>
</Error>
alexgleason commented 1 year ago

The APK download is broken, so I agree.

alexgleason commented 1 year ago

I ended up building it myself. apk is here: https://media.gleasonator.com/5fee90597e52b32ab7537a19624ea621512ea3edafdf0108568fa9cbc9d559a3.apk

tiero commented 1 year ago

I updated the APK release from EAS. The Link to the in-readme is now active again! https://expo.dev/accounts/nostr-connect/projects/nostrum/builds/f4427ee2-1c58-4a07-86a7-5f2df39b5668