search

nostr-dev-kit / ndk

Nostr Development Kit with outbox-model support
https://nostr-dev-kit.github.io/ndk/
MIT License
366 stars 99 forks source link

Event created_at gets changed when republishing someone else's kinds 0, 3 events #224

Open ptrio42 opened 6 months ago

ptrio42 commented 6 months ago

Actual result: Event created_at gets changed when republishing someone else's kinds 0, 3 events.

Expected result: When re-publishing someone else's replaceable events, event.created_at should not be changed.

erskingardner commented 6 months ago

I'm not sure what you mean here @ptrio42 when you publish a new event the created_at should be set to the new time. Can you tell me more about the scenario?

ptrio42 commented 6 months ago

Looks like this was fixed here: https://github.com/nostr-dev-kit/ndk/commit/a040a2ef83e4c6e8d181b49dfcfcd7b2f5fc5db7

isReplaceable method returned true for events kind 0 & 3 even if the event was signed by someone else.