search

nostr-protocol / nips

Nostr Implementation Possibilities
2.39k stars 582 forks source link

[NWC] Add get_budget command for per-connection budget limits. #1504

Open jklein24 opened 2 months ago

jklein24 commented 2 months ago

This separates the notion of budget from get_balance so that permissions can be more appropriately controlled by the wallet. Budgets can be configured by users like how Alby supports, and client apps can query their remaining budget and when it will renew next.

Breaking out a separate command for this purpose means that a user can let a client app see their own remaining budget without giving the app access to see their entire wallet balance.

jklein24 commented 1 month ago

Looks good to me. But we have no implementations yet, right?

I have added an issue to Alby Hub to implement this.

Thanks! We have it implemented internally, but hoping to get that live in the next couple of weeks. If there's no one to grab that ticket in alby hub and it's just in a public repo, I might be open to grabbing that ticket myself too :-)

jklein24 commented 1 month ago

Looks good to me. But we have no implementations yet, right? I have added an issue to Alby Hub to implement this.

Thanks! We have it implemented internally, but hoping to get that live in the next couple of weeks. If there's no one to grab that ticket in alby hub and it's just in a public repo, I might be open to grabbing that ticket myself too :-)

FYI @rolznz alby hub implementation is here: https://github.com/getAlby/hub/pull/726