search

nostr-protocol / nips

Nostr Implementation Possibilities
2.39k stars 582 forks source link

NIP-73 - Expand External Content IDs #1508

Closed MerryOscar closed 1 month ago

MerryOscar commented 2 months ago

Following on from the discussion around adding a Generic Comment NIP - this PR adds the extensions to the i tags that are supported in the Generic Comment kind 1111.

This PR is optional depending on whether the list of supported external content ids should be in it's own NIP or part of the Generic Comment NIP.

vitorpamplona commented 2 months ago

It would be nice to find a # equivalent for geohashes. Then people could cite them in the text, a parser could turn them into a name and a link for a feed of that location could be created.

staab commented 1 month ago

I'll merge this soon unless there are objections.

arthurfranca commented 1 month ago

Go on. I will update the comment NIP accordingly.

AsaiToshiya commented 1 month ago

How do we link i tag and k tag when multiple i tags of different types exist? Or do you think that these links are unnecessary?

staab commented 1 month ago

I don't think you would need to explicitly link them, since k tags will always be prefixes of i tags (if I understand correctly).

vitorpamplona commented 1 month ago

I think it is safer to specify and avoid misunderstandings.

staab commented 1 month ago

What do you suggest? I don't see any ambiguity.

vitorpamplona commented 1 month ago

What do you suggest?

Just keep the table with the k values to make the guidance absolutely clear.

staab commented 1 month ago

Oh, ok, I thought you were suggesting a change, you're saying keep it as is?

vitorpamplona commented 1 month ago

you're saying keep it as is?

Yep, I really like how clear it is.